Extend Response to support returning ByteBufs#1954
Merged
hyperxpro merged 1 commit intoAsyncHttpClient:mainfrom Apr 11, 2024
Merged
Extend Response to support returning ByteBufs#1954hyperxpro merged 1 commit intoAsyncHttpClient:mainfrom
hyperxpro merged 1 commit intoAsyncHttpClient:mainfrom
Conversation
NettyResponse is already dealing with ByteBufs under the hood, this lets the caller access them cleanly. This allows callers that are already using Netty to use AHC much more efficiently. Fixes AsyncHttpClient#1953
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NettyResponse is already dealing with ByteBufs under the hood, this lets the caller access them cleanly. This allows callers that are already using Netty to use AHC much more efficiently.
Fixes #1953